Code review comment for lp:~hypodermia/ubuntu/oneiric/compiz/fix-for-bug-301174

Finally got a chance to look at this.

The documentation was ambiguous when I originally made the plugin, so as
suggested here, I decided simply to test out all the options. I can confirm
that if you set CA_PROP_EVENT_ID as "bell" and don't specify a file name
that it uses the correct bell sound. Furthermore, 'bell-window-system'
actually doesn't work. Since 'bell' itself does, there's no need to specify
the file name, as far as I can tell (it seemed to be overriding the
CA_PROP_EVENT_ID setting).

I'm making the change and pushing it with the filename business entirely
removed.

On Mon, Aug 1, 2011 at 23:44, Chris Halse Rogers <email address hidden> wrote:

> The proposal to merge
> lp:~hypodermia/ubuntu/oneiric/compiz/fix-for-bug-301174 into
> lp:ubuntu/compiz has been updated.
>
> Status: Needs review => Work in progress
>
> For more details, see:
>
> https://code.launchpad.net/~hypodermia/ubuntu/oneiric/compiz/fix-for-bug-301174/+merge/64632
> --
>
> https://code.launchpad.net/~hypodermia/ubuntu/oneiric/compiz/fix-for-bug-301174/+merge/64632
> You are the owner of
> lp:~hypodermia/ubuntu/oneiric/compiz/fix-for-bug-301174.
>

--
Emily Strickland
<email address hidden>
706-363-0950