Code review comment for lp:~hyperair/ewns-viewer/autotools

On 10/07/2012 04:16, Aleksandar Jovanov wrote:
> I changed the build system completely today so you will need to change a lot
> of things. I am gracious that you made this build system. I have not seen
> your autotols files but there will be a need for a lot of changes because of
> the fact that parsers are now loaded from *.so files in
> ~/.config/ewns-viewer/parsers (and are compiled separately of course).

That shouldn't be an issue, really. Traditionally, the build system should not
touch $HOME, but only the configured installation prefix. Your method of
installation that installs half the things into $HOME, and the rest into a
global directory gets a little troublesome, because then other users on the same
system will not be able to access the files you installed into $HOME.

> Do you want to work more on ewns-viewer?
> I plan to submit this app to ubuntu software center for a price.

I know. I'm the one packaging it up on MyApps. :-)

> I am not very willing to share the money unless you do something really big.
> Hopefully you understand.

That's fine, I'm doing this on a whim.

> If you are still interested in helping me here is a short summary of things needed to get done :
> Localization support,
> Parsers test (many of them crash),
> Better UI for the ewns view (something like transmission's torrent view).
> That should be it.Have a nice day.

I can help regarding localization support, but that's about it.

--
Kind regards,
Loong Jin