Code review comment for ~hyask/autopkgtest-cloud:skia/vimrc
Revision history for this message
| Skia (hyask) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
I've updated to fix the CI.
Here are my answers:
Tim: I totally agree that there is code duplication, and I don't like that. I couldn't find what mechanism we have in place to avoid that in the charms code. The current status seems to be to duplicate the code, since there are a lot of similar functions in both charms already. Do you know of anything that could help?
Paride: about the misalignment, this is on purpose in the Python code, since we need to backslash escaping. The goal was to have proper alignment in the resulting `vimrc` file.