I think this is fine and the settings are sensible, at least until we get a team member that uses terminals with a light background. :)
Very minor nit: there is some alignment issue in the inline comments (on the match ExtraWhitespace line), but maybe that's only happening on Launchpad.
As discussed in a side channel, is it fine to have this system wide as this is going into single purpose systems, and we often need to `sudo vim`, and in that case having the vimrc to the $HOME of the unprivileged user won't work.
+1 but needs CI fix, I see you added the disable=line-too-long, but it's still failing?
I think this is fine and the settings are sensible, at least until we get a team member that uses terminals with a light background. :)
Very minor nit: there is some alignment issue in the inline comments (on the match ExtraWhitespace line), but maybe that's only happening on Launchpad.
As discussed in a side channel, is it fine to have this system wide as this is going into single purpose systems, and we often need to `sudo vim`, and in that case having the vimrc to the $HOME of the unprivileged user won't work.
+1 but needs CI fix, I see you added the disable= line-too- long, but it's still failing?