Merge ~hyask/autopkgtest-cloud:skia/fix_download-all-results into autopkgtest-cloud:master

[Skia]

[Tim Andersson (andersson123)]

we don't want all-proposed=null in the env column of the db, too much visual clutter on results pages. Please amend so this won't happen (i.e. only insert if value isn't null)

[Tim Andersson (andersson123)]

ah I just read properly, nvm

review: Approve

[Tim Andersson (andersson123)]

(approve as long as CI passes ovvi)

diff --git a/charms/focal/autopkgtest-web/webcontrol/download-all-results b/charms/focal/autopkgtest-web/webcontrol/download-all-results
index 1af7918..e0a11b0 100755
--- a/charms/focal/autopkgtest-web/webcontrol/download-all-results
+++ b/charms/focal/autopkgtest-web/webcontrol/download-all-results
@@ -175,12 +175,11 @@ def fetch_one_result(url):
         exitcode,
     )
     env_vars = []
-    env_spec = {
-        "all-proposed": "all-proposed=1",
-    }
-    for env, spec in env_spec.items():
-        if env in testinfo.keys():
-            env_vars.append(spec)
+    env_spec = ["all-proposed"]
+    for env in env_spec:
+        value = testinfo.get(env)
+        if value is not None:
+            env_vars.append("=".join([env, value]))
 
     while True:
         try: