GTG

Code review comment for lp:~huxuan/gtg/bug-907676

Revision history for this message
Izidor MatuĊĦov (izidor) wrote :

Your solution looks good and should work in the most of the situation. You might not get right this kind of situation:
" You get many requests in 20 seconds. You filter them because it is in burst. But then you have no save requests for long time like 30 minutes. Afterwards GTG crashes or user turn off the computer without closing GTG - the changes in the first 20 seconds are lost. "

Do you see that usecase? I propose to solve this bug by creating a timer which save XML and then timer is deleted. If the timer exists, save action is thrown away (it is already going to be saved). You might need to add locks to prevent modification of XML while saving XML.

review: Needs Fixing (code)

« Back to merge proposal