Code review comment for lp:~huwshimi/lazr-js/autocomplete-enter-580404
Revision history for this message
| Huw Wilkins (huwshimi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
@Martin
> I see this code was already in the keydown method and I'm just a bit curious why it's there. Does it need to happen on keydown to stop the default behaviour happening?
Where else would this code live? On keyup? I don't know why this code lives in keydown as opposed to keyup.
> Does this make it impossible to enter a prefix of an official tag as a new tag?
Yes, in a way. You can not press enter to save the form if you have any suggestions. In the prefix case you would have to enter a space in those circumstances. However, this is not a regression introduced by this branch.
@Brad
Will try and test that. I suspect it is a different issue.