Code review comment for lp:~huwshimi/lazr-js/autocomplete-enter-580404

Revision history for this message
Benji York (benji) wrote :

In testing the branch I couldn't trigger the autocomplete behavior at all, but the change did appear to work as advertised (i.e., a single enter caused the new tag value to be saved). Upon inspection I can't see any problem with the patch as given.

I would like to see a test for this behavior to prevent a regression, but I don't know what the state of our tests of browser behavior is currently so, unfortunately, that may not be practical.

review: Approve (code*)

« Back to merge proposal