Merge lp:~huwshimi/launchpad/tag-field-length-591274 into lp:launchpad

[Huw Wilkins]

[r=mbp,wgrant][ui=sinzui][bug=591274] Modified the bug tag field width so that it is a more appropriate length for the content.

Made the bug tag field wider so that it is a more appropriate length for the content.

TO TEST:

View a bug. Edit the tags (or click "add tags"). The edit field should be much wider (about the width of the bug description field.

[Martin Pool (mbp)]

review: Approve

[William Grant (wgrant)]

It would be nice if it didn't run off the edge of the page when the window got really thin. But I know how difficult that can be, and it doesn't look too bad now.

review: Approve (code*)

[Robert Collins (lifeless)]

This actually looks a little ugly to me; and it doesn't solve the root issue - we can still have too many tags for the region?

Perhaps solving that issue will have a better outcome? I'm bouncing this to sinzui for more analysis on style.

review: Abstain

[Curtis Hovey (sinzui)]

I think this branch is fine to land. I agree this does not address the root issue. I think this might be a be a fix for 80% or more of affected users. I think we can let the users judge if this is good enough. This is a long text input (which is what I think Robert means by ugly), and my instinct is that anyone exceeding this length is putting useless information in it.

review: Approve (ui)

[Huw Wilkins (huwshimi)]

> This actually looks a little ugly to me; and it doesn't solve the root issue -
> we can still have too many tags for the region?

One option would be to use a widget like we use for editing descriptions where the textarea grows vertically (with a textarea). This might add some interesting issues (like when you are editing a tag where do the suggestions appear).

=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2011-02-17 01:03:34 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2011-02-24 05:55:41 +0000
@@ -139,7 +139,7 @@
                  tal:attributes="href string:${context/target/fmt:url}/+bugs?field.tag=${tag}">tag</a>
             </span>
             <form id="tags-form" style="display: inline">
-                <input type="text" id="tag-input" style="display: none; width: 15em;" />
+                <input type="text" id="tag-input" style="display: none; width: 35em;" />
                 <img src="/@@/spinner" id="tags-edit-spinner" style="display: none" />
                 <a href="+edit" title="Edit tags" id="edit-tags-trigger" class="sprite edit"></a>
               <script type="text/javascript">