Code review comment for lp:~huwshimi/launchpad/remove-icon-alt-528367

Revision history for this message
Gavin Panella (allenap) wrote :

> There's certainly no standard way of doing that. I guess we could do
> something like have a whole bunch of templates with img tags in them
> set up for each image and we just include that. However, I think
> it's just the nature of html to have alt tags on images. Personally
> I think it's something that should be picked up in UI reviews.

Agreed, I don't think the template thing would work; we'd have to
check that they're used in review anyway. But your review point made
me think...

We could have a linter to check these things. Without looking I'm
going to guess that there are over 100,000 html lint tools out there,
all of which melt when exposed to TAL.

However, a linter for just this could be botched together fairly
easily, and additional checks added as we go along. (Btw, I'm not
suggesting you do it.)

Consider filing a bug to add a template linter with an importance
roughly equal to how important alt attributes are to have on img tags.

« Back to merge proposal