Code review comment for lp:~huwshimi/launchpad/private-objects-298152

Revision history for this message
Huw Wilkins (huwshimi) wrote :

> Thanks for this change. My only request is that we move the JS you've added to
> bugtask-index.pt into lib/lp/bugs/javascript/bugtask_index.js so that we can
> keep the JS neat(ish) and in one place.

Thanks, that's been done.

I also found a bug when changing the bug between private to public where it would not show/hide the banner. This has been fixed, but required some big changes to the code.

« Back to merge proposal