Code review comment for lp:~huwshimi/launchpad/avatars-everywhere-712894

Revision history for this message
Robert Collins (lifeless) wrote :

I haven't triple-checked this, but there is a decent chance this will cause widespread timeouts due to lazy evaluation of the logo (vs the icon).

getPrecachedPersonsFromIDs is the primary eager loading function to update, changing from need_icon to need_logo, and so on down the call chain from there.

(Reason being, that loading even the icons for 50 people can take a significant chunk of time, and some pages like blueprint reports load the icons for hundreds of people).

I'm going to mark this needs fixing, because I fully expect this problem to crop up. However, if you want to land it under a feature flag, so that widespread testing can be done, that would be fine with me.

I haven't done a detailed review, sorry.

review: Needs Fixing

« Back to merge proposal