Code review comment for lp:~huwshimi/juju-gui/yui3-skin-sam-removal

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Remove yui3-skin-sam

We were not really making use of the yui3-skin-sam classes, except in a
few minor cases.

I've removed those classes from our HTML and fixed any fallout.

I've also updated our CSS merging script to manually include just the
core CSS files that we require.

Rick suggested overriding the Loader to not pull in the sam skin files,
but in the end I need to abandon the Loader's auto-discovered files as
it still included files we did not want.

I've left a few comments in the merge file about including files, but if
there are additional places I need to add documentation I'd be happy to
do so.

R=gary.poster
CC=
https://codereview.appspot.com/20120044

https://codereview.appspot.com/20120044/

« Back to merge proposal