Merge lp:~humitos/encuentro/keep-trying-after-fail into lp:encuentro

[Facundo Batista]

Keep trying to download failed episodes

[Facundo Batista (facundo)]

I don't like the "start from the first not downloaded after finishing the list" behaviour.

Yes, it's a good idea to retry those that failed. But what if it fails because of a non-spurious error (e.g., because the URL is wrong, or the video was removed in the backend, etc)?

In that case, the program will be in an endless loop, not only consuming local resources, but also hammering the backend services over and over again, getting the same error.

On the other hand, I like a lot the idea of marking specially the episode so it's kept after closing/opening the program. But it must not be 'waiting'... maybe something like 'failed', because of the program buttons (with 'waiting' it will not turn on the 'download' button, for example).

Maybe you could re-purpose this branch? Thanks!

review: Needs Fixing

Unmerged revisions

208. By Manuel Kaufmann on 2014-04-23

Keep trying to download failed episodes

When a download fails, Encuentro marks that episode as "State.waiting"
to try again later (once Encuentro reaches the end of the list).

All of the episodes that failed in the download process are saved to
disk when Encuentro is closed and load again when Encuentro is opened.

=== modified file 'encuentro/ui/central_panel.py'
--- encuentro/ui/central_panel.py	2014-04-26 02:36:13 +0000
+++ encuentro/ui/central_panel.py	2014-04-28 01:26:07 +0000
@@ -1,4 +1,4 @@
-# -*- coding: UTF-8 -*-
+# -*- coding: utf-8 -*-
 
 # Copyright 2013-2014 Facundo Batista
 #
@@ -92,7 +92,12 @@
         """Set up everything for next download."""
         self.downloading = True
         self.current += 1
-        episode, _ = self.queue[self.current]
+        try:
+            episode, _ = self.queue[self.current]
+        except IndexError:
+            # get the first pending episode
+            episode, _ = self.pending()[0]
+            self.current = self.queue.index((episode, _))
         episode.state = Status.downloading
         return episode
 
@@ -100,6 +105,7 @@
         """Download started."""
         episode, item = self.queue[self.current]
         item.setText(1, u"Comenzando")
+        item.setDisabled(False)
         episode.state = Status.downloading
 
     def progress(self, progress):
@@ -117,7 +123,8 @@
         else:
             # something bad happened
             gui_msg = unicode(error)
-            end_state = Status.none
+            # mark as waiting to try again later
+            end_state = Status.waiting
         item.setText(1, gui_msg)
         item.setDisabled(True)
         episode.state = end_state
@@ -150,21 +157,19 @@
         self.episodes_widget.show(item.episode_id)
 
     def pending(self):
-        """Return the pending downloads quantity (including current)."""
-        # remaining after current one
-        q = len(self.queue) - self.current - 1
-        # if we're still downloading current one, add it to the count
-        if self.downloading:
-            q += 1
-        return q
+        pending_episodes = []
+        for episode, item in self.queue:
+            if episode.state in (Status.waiting, Status.none):
+                pending_episodes.append((episode, item))
+        return pending_episodes
 
     def save_state(self):
         """Save state for pending downloads."""
-        p = self.pending()
-        if p > 0:
-            pending_ids = [e.episode_id for e, _ in self.queue[-p:]]
+        if self.pending():
+            pending_ids = [e.episode_id for e, _ in self.pending()]
         else:
             pending_ids = []
+
         config[config.SYSTEM]['pending_ids'] = pending_ids
 
     def load_pending(self):