Merge lp:~humitos/encuentro/keep-trying-after-fail into lp:encuentro
Proposed by
Facundo Batista
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~humitos/encuentro/keep-trying-after-fail | ||||
Merge into: | lp:encuentro | ||||
Diff against target: |
71 lines (+18/-13) 1 file modified
encuentro/ui/central_panel.py (+18/-13) |
||||
To merge this branch: | bzr merge lp:~humitos/encuentro/keep-trying-after-fail | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Facundo Batista | Needs Fixing | ||
Review via email: mp+217375@code.launchpad.net |
Description of the change
Keep trying to download failed episodes
To post a comment you must log in.
Unmerged revisions
- 208. By Manuel Kaufmann
-
Keep trying to download failed episodes
When a download fails, Encuentro marks that episode as "State.waiting"
to try again later (once Encuentro reaches the end of the list).All of the episodes that failed in the download process are saved to
disk when Encuentro is closed and load again when Encuentro is opened.
I don't like the "start from the first not downloaded after finishing the list" behaviour.
Yes, it's a good idea to retry those that failed. But what if it fails because of a non-spurious error (e.g., because the URL is wrong, or the video was removed in the backend, etc)?
In that case, the program will be in an endless loop, not only consuming local resources, but also hammering the backend services over and over again, getting the same error.
On the other hand, I like a lot the idea of marking specially the episode so it's kept after closing/opening the program. But it must not be 'waiting'... maybe something like 'failed', because of the program buttons (with 'waiting' it will not turn on the 'download' button, for example).
Maybe you could re-purpose this branch? Thanks!