Code review comment for lp:~hui.wang/unity-settings-daemon/unity-settings-daemon

Hello Seb,

The option 2 is fine, it is best that two fixes to be SRUed together. :-)

Thanks,
Hui.

On 03/25/2015 04:07 PM, Sebastien Bacher wrote:
> Hey Hui,
>
> We could probably SRU it now, there are some issues though like [1] the
> fact that indicator menus are misplaced on the greeter when hidpi
> scaling on. We could have a first SRU to try to activate it only for the
> installer/oem config (we just need to find e.g an env variable specific
> to those sessions) or wait to have a fix for the unity-greeter issue and
> SRU that as well.
> Do you have a preference for one of those options?
>
> Cheers,
> Sebastien Bacher
>
> [1] https://bugs.launchpad.net/ubuntu/+source/unity-greeter/+bug/1434094
>
> Le 25/03/2015 07:37, Hui Wang a écrit :
>> Hello Sebastien,
>>
>> Our OEM project has been waiting this fix to be merged to Trusty
>> (14.04) , is it possible we do that now? If you need me to do
>> something, just let me know.
>>
>>
>> Thanks,
>> Hui.
>
>