> David, could you comment on whether "GVC_IS_MIXER_SINK (stream)" is the right way to check if the right way to tell a mic appart from an output?
I suppose so, since it is already used that way a few lines down.
In short, assuming Hui has properly tested his patch, I see no problems with it.
Nitpick: perhaps get_icon_name_for_volume can now be refactored to use the global definitions of "icon_names" and "mic_icon_names" instead of copy-pasted local ones.
> David, could you comment on whether "GVC_IS_MIXER_SINK (stream)" is the right way to check if the right way to tell a mic appart from an output?
I suppose so, since it is already used that way a few lines down.
In short, assuming Hui has properly tested his patch, I see no problems with it.
Nitpick: perhaps get_icon_ name_for_ volume can now be refactored to use the global definitions of "icon_names" and "mic_icon_names" instead of copy-pasted local ones.