Merge lp:~hsoft/openerp-mgmtsystem/bug-1167918 into lp:openerp-mgmtsystem

[Virgil Dupras]

[Daniel Reis (dreis-pt)]

The problem is that the code is trying to run a method on a Browse object, and it should do it on a Model object instead. Instead of "o." it should use a "nc_model." Pointing at a pool's model.

[Virgil Dupras (hsoft)]

My knowledge is fuzzy on calling methods on a Browse object being a bad practice.

If it's a bad practice, why does it seem to work? The "function_proxy" thing seems to have been added with the intent of adding this feature.

http://bazaar.launchpad.net/~openerp/openobject-server/trunk/revision/3353.1.43

[Daniel Reis (dreis-pt)]

Well, if it works, I'm learning something new. I'll need to have a closer look at that.

No dia 11/04/2013, às 21:09, Virgil Dupras <email address hidden> escreveu:

> My knowledge is fuzzy on calling methods on a Browse object being a bad practice.
>
> If it's a bad practice, why does it seem to work? The "function_proxy" thing seems to have been added with the intent of adding this feature.
>
> http://bazaar.launchpad.net/~openerp/openobject-server/trunk/revision/3353.1.43
> --
> https://code.launchpad.net/~hsoft/openerp-mgmtsystem/bug-1167918/+merge/158458
> You are subscribed to branch lp:openerp-mgmtsystem.

[Daniel Reis (dreis-pt)]

I tested the NC workflow and all stages worked, including the "Open/Start".
And the syntax used is a lot more object oriented than the previues one, so well done.

review: Approve

=== modified file 'mgmtsystem_nonconformity/mgmtsystem_nonconformity.py'
--- mgmtsystem_nonconformity/mgmtsystem_nonconformity.py	2013-04-02 14:39:52 +0000
+++ mgmtsystem_nonconformity/mgmtsystem_nonconformity.py	2013-04-11 19:24:20 +0000
@@ -244,10 +244,10 @@
         self.message_post(cr, uid, self.browse(cr, uid, ids, context=context), _('In Progress'))
         #Open related Actions
         if o.immediate_action_id and o.immediate_action_id.state == 'draft':
-            o.immediate_action_id.case_open(cr, uid, [o.immediate_action_id.id])
+            o.immediate_action_id.case_open()
         for a in o.action_ids:
             if a.state == 'draft':
-                a.case_open(cr, uid, [a.id])
+                a.case_open()
         return self.write(cr, uid, ids, {'state': 'open', 'evaluation_date': None, 'evaluation_user_id': None}, context=context)
 
     def action_sign_evaluation(self, cr, uid, ids, context=None):