Code review comment for lp:~hrvojem/percona-server/rn-5.6.13-60.6

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

   Not commenting on the missing stuff as this is a draft.

   - Line 44: remove whitespace before "=", and "CREATE,DROP,LOCK
   TABLES"
   - Line 64: s/CSV/comma-separated, missing space before EXECUTE.
   - Line 74: release date.
   - "The unnecessary overhead from persistent InnoDB adaptive hash
   index latching has been removed, potentially improving the
   stability of (AHI partitions link) feature as well. Bug fixed ... "
   - Move bug 1216804/62018 up to the "feature has been ported",
     assign its explaining the text to the feature instead.
   - Line 107: s/hash index memory/hash index memory size
   - "An unncessary buffer pool mutex acquisition has been removed,
     potentially improving performance".
   - 70228 goes to "other fixes".
   - "Adaptive hash indexing partitioning code has been simplified,
     potentially improving performance".

review: Needs Fixing

« Back to merge proposal