Code review comment for lp:~hrvojem/percona-server/rn-5.5.36-34.0-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Partial review till 256:

    - 156: add "The slow query log files will be named using (link
      slow_query_log_file) as a stem, to which a dot and a sequence
      number will be appended."
    - 194: "When this number is reached server will use the oldest
      slow query log file instead of starting a new one." - it sounds
      as if the oldest log file will be reopened for further writing
      while keeping its sequence number, but I guess it will be
      deleted and a new file with a current sequence number will
      started?
    - 249: In order to comply with Linux distribution packaging
      standards |Percona|'s version of ``libmysqlclient`` has been
      renamed to ``libperconaserver``. The old name was conflicting
      with the upstream libmysqlclient. Except for packaging,
      ``libmysqlclient`` and ``libperconaserverclient`` of the same
      version do not have any differences. Users wishing to continue
      using ``libmysqlclient`` will have to install the corresponding
      package of their distribution, such as ``mysql-lib``
      for *CentOS* and ``libmysqlclient18`` for *Ubuntu*/*Debian*.
      Users wishing to build software against
      ``libperconaserverclient`` should install
      ``libperconaserverclient-dev`` package. An old version of
      Percona-built ``libmysqlclient`` will be available for download
      at ...
   - 1159625: missing word "packages" after the link?
   - 256: were or was, depending on produced output

review: Needs Fixing

« Back to merge proposal