Code review comment for lp:~hrvojem/percona-server/rn-5.5.36-34.0-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

   - For 5.1 and 5.5 too: I am not sure why --rewrite-db is called a
     "variable". It's an option.
   - 173: s/the/its
   - max_slowlog_files needs a description what happens when the
     number is exceeded (the oldest one is deleted?)
   - 1277383: the XtraDB version number in univ.i was incorrect.
   - 1159625: missing word "packages" after the link?
   - 1249193: server could crash if it was signalled with SIGHUP early
     in the server startup.
   - 758788/1250018: server could crash if XtraDB innodb_dict_size
     option was set due to incorrect attempts to remove indexes in use
     from the dictionary cache.
   - 1269352: ...a combination of write workload and tablespace drop
     could crash the server if InnoDB compression was used.
   - 1229598: where does Scientific Linux 6.2 come from?
   - 1244178: Percona Server that was compiled from source package had
     differrent server version string from binary packages.
   - 1005787: let's piggyback to 1014477.

review: Needs Fixing

« Back to merge proposal