Merge lp:~hrvojem/percona-server/enforce_engine_docs into lp:percona-server/5.5

Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 251
Proposed branch: lp:~hrvojem/percona-server/enforce_engine_docs
Merge into: lp:percona-server/5.5
Diff against target: 52 lines (+37/-0)
2 files modified
doc/source/index.rst (+1/-0)
doc/source/management/enforce_engine.rst (+36/-0)
To merge this branch: bzr merge lp:~hrvojem/percona-server/enforce_engine_docs
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Alexey Kopytov (community) Approve
Laurynas Biveinis (community) Approve
Review via email: mp+106428@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

In 5.5, the default storage engine is InnoDB rather than MyISAM unless specified otherwise with default_storage_engine. I suggest to s/MyISAM/the default storage engine/

See:

http://dev.mysql.com/doc/refman/5.5/en/server-sql-mode.html#sqlmode_no_engine_substitution
http://dev.mysql.com/doc/refman/5.5/en/server-options.html#option_mysqld_default-storage-engine

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Note that the MySQL manual uses uppercase for SQL modes, i.e. NO_ENGINE_SUBSTITUTION, but lowercase for variable names, i.e. sql_mode.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

LGTM, thanks.

(Please wait for Alexey's review too)

review: Approve
Revision history for this message
Stewart Smith (stewart) :
review: Approve
Revision history for this message
Stewart Smith (stewart) wrote :

FYI, I've pushed this to the 5.5.24-26.0 release branch so that docs will be included in the release.

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hrvoje,

I don't understand why you have removed all mentions of SQL modes. It may not be obvious what enabling "NO_ENGINE_SUBSTITUTION`" refers to. Perhaps you meant to say "the NO_ENGINE_SUBSTITUTION SQL mode"?

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve
Revision history for this message
Stewart Smith (stewart) wrote :

 review approve
--
Stewart Smith

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/source/index.rst'
--- doc/source/index.rst 2012-03-27 09:09:14 +0000
+++ doc/source/index.rst 2012-05-21 06:50:26 +0000
@@ -122,6 +122,7 @@
122 management/udf_maatkit122 management/udf_maatkit
123 management/innodb_fake_changes123 management/innodb_fake_changes
124 management/innodb_kill_idle_trx124 management/innodb_kill_idle_trx
125 management/enforce_engine
125126
126Diagnostics Improvements127Diagnostics Improvements
127========================128========================
128129
=== added file 'doc/source/management/enforce_engine.rst'
--- doc/source/management/enforce_engine.rst 1970-01-01 00:00:00 +0000
+++ doc/source/management/enforce_engine.rst 2012-05-21 06:50:26 +0000
@@ -0,0 +1,36 @@
1.. _enforce_engine:
2
3========================
4Enforcing Storage Engine
5========================
6
7|Percona Server| has implemented variable which can be used for enforcing the use of a specific storage engine.
8
9When this variable is specified and a user tries to create a table using an explicit storage engine that is not the specified enforced engine, he will get either an error if the ``NO_ENGINE_SUBSTITUTION`` SQL mode is enabled or a warning if ``NO_ENGINE_SUBSTITUTION`` is disabled and the table will be created anyway using the enforced engine (this is consistent with the default |MySQL| way of creating the default storage engine if other engines aren't available unless ``NO_ENGINE_SUBSTITUTION`` is set).
10
11In case user tries to enable enforce_storage_engine with engine that isn't available, system will not start.
12
13Version Specific Information
14============================
15
16 * 5.5.24-26.0
17 Variable :variable:`enforce_storage_engine` implemented.
18
19System Variables
20================
21
22.. variable:: enforce_storage_engine
23
24 :cli: No
25 :conf: Yes
26 :scope: Global
27 :dyn: No
28 :vartype: String
29 :default: NULL
30
31Example
32=======
33
34Adding following option to :term:`my.cnf` will start the server with InnoDB as enforced storage engine. ::
35
36 enforce_storage_engine=InnoDB

Subscribers

People subscribed via source and target branches