Code review comment for lp:~hrvojem/percona-server/doc-28

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - innodb_io.rst: innodb_flush_method=ALL_O_DIRECT (dropped),
      innodb_log_file_size (replaced in upstream) have not been
      ported. innodb_purge_threads default has not been ported
      (replaced in upstream). That leaves ported status vars,
      innodb_log_block_size, and
      innodb_use_global_flush_log_at_trx_commit. The introduction
      needs updating, it doesn't seem to have received any since 5.0,
      i.e. "Note that some of these parameters are already available
      in the |InnoDB| plugin." should be removed, the rest rewritten
      perhaps.

review: Needs Fixing

« Back to merge proposal