Code review comment for lp:~hrvojem/percona-server/bug930571-5.1

Revision history for this message
Stewart Smith (stewart) wrote :

I think the following could be fixed, although it's not going to stop me merging this tree as is:

In "Relocation of the doublewrite buffer", "turned on/off without breaking the compatibility." can drop the "the".

In "doc/source/diagnostics/misc_info_schema_tables.rst", "Only the temporary tables that were explicitly created with `CREATE TEMPORARY TABLE` or `ALTER TABLE` are shown, and not the ones created to process complex queries." should drop the first "the" and "to process complex queries" should be replaced with "during query execution".

In "innodb_fake_changes.rst", "Restarting a slave server in a replication environment or setting up new slave server can cause a replication reads slower. This is happening because replication in |MySQL| is single-threaded and because it needs to read the data before it can execute the queries. The process can be speeded up by having prefetch threads to warm the server: replay statements and then rollback at commit." should be "Replication in |MySQL| is single-threaded and because it needs to read the data before it can execute the queries, this can decrease performance when the full data set is not already in the buffer pool. The fake changes feature allows a process to replay a set of operations against a replication slave to warm the buffer pool for the replication apply thread."

review: Approve

« Back to merge proposal