Code review comment for lp:~hrvojem/percona-server/bug1186987-5.6

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - What is the relation between innodb-fast-index-creation and
      innodb-fast-checksums? Won't the latter, when enabled on 5.5,
      prevent any in-place upgrade to 5.6, regardless of
      innodb-fast-index-creation?
    - Line 151: s/about this/about temporary tables
    - I Innodb_adaptive_hash_cells -> adaptive_hash_rows_added mapping
      is not correct. The hash cells variable counts the internal
      hash table size and the hash table uses link chaining, thus no
      relation to the "rows" which are the logical data entries stored
      there. (probably related to data rows but unable to check right
      now).
    - Likewise Innodb_adaptive_hash_heap_buffers is accounting hash
      table memory usage, while adaptive_hash_pages_added is
      accounting the number hash-indexed buffer pool data pages.
    - Line 253, 255: s/upstream/the upstream.

review: Needs Fixing

« Back to merge proposal