Code review comment for lp:~hrvojem/percona-server/bug1186987-5.6

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - My previous review comment re. Com_show_temporary_tables is not
      addressed. Currently it is unclear what "Information" is the
      text referring to.
    - Re. INNODB_METRICS, please point not to the module but to the
      monitor, see the table in Oracle docs that lists
      adaptive_hash_pages_added etc.
    - I suggest to add wording next to 5.6 table_definition_cache to
      explain that this variable has a new extra meaning in 5.6 for
      InnoDB, as otherwise both its presence in the earlier versions
      and its name are counterintuitive.

review: Needs Fixing

« Back to merge proposal