Code review comment for lp:~hopem/charms/trusty/swift-proxy/lp1448884

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Hey Chris, sure thing and thanks for the review.

I've added README.Swift_ring_management with a basic explanation of swift ring
and builder management in the charm. We can always add more overtime as-and-when.

First i'd like to stress that this is mostly a refactor (upgrade safe) that is aimed at making the ring sync process more robust and cleaner to facilitate easier debugging.

With regards to:

   deleting nodes - for storage nodes, this is currently a manual process and
                    something that we need to grow the ability to do in the
                    charm (probably using actions). For proxy units,
                    information about proxy units/hosts is not in the
                    rings/builders so as long as they are synced and the leader
                    switches, removing a proxy unit should not interrupt
                    service.

   repairing nodes - again, same as above

I've responded to your comment inline as well.

« Back to merge proposal