Juju Charms Collection
percona-cluster package

Code review comment for lp:~hopem/charms/trusty/percona-cluster/min-cluster-size

  1. Trusty Tahr (14.04)
  2. min-cluster-size
  3. Merge into next
Revision history for this message
David Ames (thedac) wrote :

Ed,

This looks good and appears to solve bug 1475585.

I am new here but it seems we want to keep the *_hooks.py as clean as possible and have these helper functions in the *_utils.py. For example is_bootstrapped and get_wsrep_value and possibly all of the new functions could be moved over to the utils
functions into perconal_utils.py

This should really get its own amulet test. Setup with min-cluster-size, add min-cluster-size -1, verify percona has not started
, add another unit and verify it all comes up.

Lastly, is "boostrap-pxc mysql" idempotent? If any config change changes the config file this gets run. On a stable cluster would "boostrap-pxc mysql" being run break anything?

review: Needs Fixing

« Back to merge proposal