Merge lp:~hopem/charms/trusty/nova-cloud-controller/next.lp1273022 into lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by Edward Hope-Morley
Status: Superseded
Proposed branch: lp:~hopem/charms/trusty/nova-cloud-controller/next.lp1273022
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 35 lines (+11/-1)
3 files modified
config.yaml (+5/-0)
revision (+1/-1)
templates/parts/section-database (+5/-0)
To merge this branch: bzr merge lp:~hopem/charms/trusty/nova-cloud-controller/next.lp1273022
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Haw Loeung Pending
Review via email: mp+234516@code.launchpad.net

This proposal supersedes a proposal from 2014-07-16.

This proposal has been superseded by a proposal from 2014-10-10.

To post a comment you must log in.
Revision history for this message
James Page (james-page) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

Hey James, this was merged a while back into lp:charm-helpers and lp:~openstack-charmers/charm-helpers/stable (revision 114) and since this MP has been around for a while it also looks like the charm-helpers sync was done (by you) in revision 63 of this charm. So all that is left is this bit.

Revision history for this message
James Page (james-page) wrote :

I think we cut our losses and just provide this for >= icehouse - please drop the folsom template updates and the associated _utils bits.

review: Needs Fixing
Revision history for this message
Edward Hope-Morley (hopem) wrote :

@jamespage fixed.

91. By Edward Hope-Morley

trunk sync

92. By Edward Hope-Morley

fixed review comments

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-10-06 21:01:49 +0000
+++ config.yaml 2014-10-06 22:08:14 +0000
@@ -139,6 +139,11 @@
139 type: string139 type: string
140 default:140 default:
141 description: SSL key to use with certificate specified as ssl_cert.141 description: SSL key to use with certificate specified as ssl_cert.
142 neutron-alchemy-flags:
143 type: string
144 description: |
145 Comma separated list of key=value sqlalchemy related config flags to be
146 set in plugin ini file.
142 ssl_ca:147 ssl_ca:
143 type: string148 type: string
144 default:149 default:
145150
=== modified file 'revision'
--- revision 2014-04-25 16:46:42 +0000
+++ revision 2014-10-06 22:08:14 +0000
@@ -1,1 +1,1 @@
15001501
22
=== modified file 'templates/parts/section-database'
--- templates/parts/section-database 2014-05-02 09:21:30 +0000
+++ templates/parts/section-database 2014-10-06 22:08:14 +0000
@@ -2,3 +2,8 @@
2[database]2[database]
3connection = {{ database_type }}://{{ database_user }}:{{ database_password }}@{{ database_host }}/{{ database }}{% if database_ssl_ca %}?ssl_ca={{ database_ssl_ca }}{% if database_ssl_cert %}&ssl_cert={{ database_ssl_cert }}&ssl_key={{ database_ssl_key }}{% endif %}{% endif %}3connection = {{ database_type }}://{{ database_user }}:{{ database_password }}@{{ database_host }}/{{ database }}{% if database_ssl_ca %}?ssl_ca={{ database_ssl_ca }}{% if database_ssl_cert %}&ssl_cert={{ database_ssl_cert }}&ssl_key={{ database_ssl_key }}{% endif %}{% endif %}
4{% endif -%}4{% endif -%}
5{% if neutron_alchemy_flags -%}
6{% for key, value in neutron_alchemy_flags.iteritems() -%}
7{{ key }} = {{ value }}
8{% endfor -%}
9{% endif -%}

Subscribers

People subscribed via source and target branches