Merge lp:~hopem/charms/trusty/nova-cloud-controller/charm-helpers-sync-precise-ipv6-haproxy into lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 131
Proposed branch: lp:~hopem/charms/trusty/nova-cloud-controller/charm-helpers-sync-precise-ipv6-haproxy
Merge into: lp:~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 47 lines (+11/-2)
3 files modified
hooks/charmhelpers/contrib/openstack/context.py (+1/-0)
hooks/charmhelpers/contrib/openstack/neutron.py (+8/-2)
hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg (+2/-0)
To merge this branch: bzr merge lp:~hopem/charms/trusty/nova-cloud-controller/charm-helpers-sync-precise-ipv6-haproxy
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Liam Young (community) Approve
Review via email: mp+245223@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #320 nova-cloud-controller-next for hopem mp245223
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/320/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #349 nova-cloud-controller-next for hopem mp245223
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/349/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #482 nova-cloud-controller-next for hopem mp245223
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/482/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

confirmed a-ok on p-i, t-i, t-j, u-j. thank you, all!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/charmhelpers/contrib/openstack/context.py'
--- hooks/charmhelpers/contrib/openstack/context.py 2014-12-15 09:29:56 +0000
+++ hooks/charmhelpers/contrib/openstack/context.py 2014-12-19 17:35:50 +0000
@@ -491,6 +491,7 @@
491 ctxt['haproxy_client_timeout'] = config('haproxy-client-timeout')491 ctxt['haproxy_client_timeout'] = config('haproxy-client-timeout')
492492
493 if config('prefer-ipv6'):493 if config('prefer-ipv6'):
494 ctxt['ipv6'] = True
494 ctxt['local_host'] = 'ip6-localhost'495 ctxt['local_host'] = 'ip6-localhost'
495 ctxt['haproxy_host'] = '::'496 ctxt['haproxy_host'] = '::'
496 ctxt['stat_port'] = ':::8888'497 ctxt['stat_port'] = ':::8888'
497498
=== modified file 'hooks/charmhelpers/contrib/openstack/neutron.py'
--- hooks/charmhelpers/contrib/openstack/neutron.py 2014-12-10 20:28:55 +0000
+++ hooks/charmhelpers/contrib/openstack/neutron.py 2014-12-19 17:35:50 +0000
@@ -152,9 +152,15 @@
152 database=config('neutron-database'),152 database=config('neutron-database'),
153 relation_prefix='neutron',153 relation_prefix='neutron',
154 ssl_dir=NEUTRON_CONF_DIR)],154 ssl_dir=NEUTRON_CONF_DIR)],
155 'services': ['calico-compute', 'bird', 'neutron-dhcp-agent'],155 'services': ['calico-felix',
156 'bird',
157 'neutron-dhcp-agent',
158 'nova-api-metadata'],
156 'packages': [[headers_package()] + determine_dkms_package(),159 'packages': [[headers_package()] + determine_dkms_package(),
157 ['calico-compute', 'bird', 'neutron-dhcp-agent']],160 ['calico-compute',
161 'bird',
162 'neutron-dhcp-agent',
163 'nova-api-metadata']],
158 'server_packages': ['neutron-server', 'calico-control'],164 'server_packages': ['neutron-server', 'calico-control'],
159 'server_services': ['neutron-server']165 'server_services': ['neutron-server']
160 }166 }
161167
=== modified file 'hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg'
--- hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg 2014-12-10 20:28:55 +0000
+++ hooks/charmhelpers/contrib/openstack/templates/haproxy.cfg 2014-12-19 17:35:50 +0000
@@ -38,7 +38,9 @@
38{% for service, ports in service_ports.items() -%}38{% for service, ports in service_ports.items() -%}
39frontend tcp-in_{{ service }}39frontend tcp-in_{{ service }}
40 bind *:{{ ports[0] }}40 bind *:{{ ports[0] }}
41 {% if ipv6 -%}
41 bind :::{{ ports[0] }}42 bind :::{{ ports[0] }}
43 {% endif -%}
42 {% for frontend in frontends -%}44 {% for frontend in frontends -%}
43 acl net_{{ frontend }} dst {{ frontends[frontend]['network'] }}45 acl net_{{ frontend }} dst {{ frontends[frontend]['network'] }}
44 use_backend {{ service }}_{{ frontend }} if net_{{ frontend }}46 use_backend {{ service }}_{{ frontend }} if net_{{ frontend }}

Subscribers

People subscribed via source and target branches