Merge lp:~hopem/charms/trusty/neutron-gateway/lp1485655 into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 135
Proposed branch: lp:~hopem/charms/trusty/neutron-gateway/lp1485655
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 26 lines (+7/-1)
2 files modified
charm-helpers-hooks.yaml (+1/-1)
config.yaml (+6/-0)
To merge this branch: bzr merge lp:~hopem/charms/trusty/neutron-gateway/lp1485655
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+268265@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #8249 neutron-gateway-next for hopem mp268265
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/8249/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7648 neutron-gateway-next for hopem mp268265
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7648/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5849 neutron-gateway-next for hopem mp268265
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5849/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #8251 neutron-gateway-next for hopem mp268265
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/8251/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7650 neutron-gateway-next for hopem mp268265
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7650/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5851 neutron-gateway-next for hopem mp268265
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5851/

133. By Edward Hope-Morley

[hopem,r=]

Ensure all nics are included when resolving mac addresses
and filter out virtual interfaces.

Closes-Bug: 1485655

134. By Edward Hope-Morley

sync

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #8284 neutron-gateway-next for hopem mp268265
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/8284/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7682 neutron-gateway-next for hopem mp268265
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7682/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5875 neutron-gateway-next for hopem mp268265
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5875/

135. By Edward Hope-Morley

sync /next

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charm-helpers-hooks.yaml'
--- charm-helpers-hooks.yaml 2015-08-03 14:52:53 +0000
+++ charm-helpers-hooks.yaml 2015-08-20 09:17:21 +0000
@@ -1,4 +1,4 @@
1branch: lp:charm-helpers1branch: lp:~hopem/charm-helpers/allow-list-nics-return-all
2destination: hooks/charmhelpers2destination: hooks/charmhelpers
3include:3include:
4 - core4 - core
55
=== modified file 'config.yaml'
--- config.yaml 2015-07-10 14:18:52 +0000
+++ config.yaml 2015-08-20 09:17:21 +0000
@@ -79,6 +79,12 @@
79 their corresponding bridge. The bridges will allow usage of flat or79 their corresponding bridge. The bridges will allow usage of flat or
80 VLAN network types with Neutron and should match this defined in80 VLAN network types with Neutron and should match this defined in
81 bridge-mappings.81 bridge-mappings.
82 .
83 Ports provided can be the name or MAC address of the interface to be
84 added to the bridge. If MAC addresses are used, you may provide multiple
85 bridge:mac for the same bridge so as to be able to configure multiple
86 units. In this case the charm will run through the provided MAC addresses
87 for each bridge until it finds one it can resolve to an interface name.
82 run-internal-router:88 run-internal-router:
83 type: string89 type: string
84 default: all90 default: all

Subscribers

People subscribed via source and target branches