Merge lp:~hopem/charms/trusty/keystone/fix-legacy-import-error into lp:~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 132
Proposed branch: lp:~hopem/charms/trusty/keystone/fix-legacy-import-error
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 17 lines (+6/-1)
1 file modified
hooks/keystone_utils.py (+6/-1)
To merge this branch: bzr merge lp:~hopem/charms/trusty/keystone/fix-legacy-import-error
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+250315@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2115 keystone-next for hopem mp250315
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2115/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1905 keystone-next for hopem mp250315
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1905/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2024 keystone-next for hopem mp250315
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2024/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2117 keystone-next for hopem mp250315
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/2117/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1907 keystone-next for hopem mp250315
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1907/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #2026 keystone-next for hopem mp250315
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/2026/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/keystone_utils.py'
--- hooks/keystone_utils.py 2015-02-16 23:56:01 +0000
+++ hooks/keystone_utils.py 2015-02-19 14:40:55 +0000
@@ -582,7 +582,12 @@
582 # Allow retry on fail since leader may not be ready yet.582 # Allow retry on fail since leader may not be ready yet.
583 # NOTE(hopem): ks client may not be installed at module import time so we583 # NOTE(hopem): ks client may not be installed at module import time so we
584 # use this wrapped approach instead.584 # use this wrapped approach instead.
585 from keystoneclient.apiclient.exceptions import InternalServerError585 try:
586 from keystoneclient.apiclient.exceptions import InternalServerError
587 except:
588 # Backwards-compatibility for earlier versions of keystoneclient (< I)
589 from keystoneclient.exceptions import (ClientException as
590 InternalServerError)
586591
587 @retry_on_exception(3, base_delay=3, exc_type=InternalServerError)592 @retry_on_exception(3, base_delay=3, exc_type=InternalServerError)
588 def _ensure_initial_admin(config):593 def _ensure_initial_admin(config):

Subscribers

People subscribed via source and target branches