Juju Charms Collection
ceph-radosgw package

Code review comment for lp:~hopem/charms/trusty/ceph-radosgw/lp1513524

  1. Trusty Tahr (14.04)
  2. lp1513524
  3. Merge into next
Revision history for this message
Chris Holcombe (xfactor973) wrote :

Hey Ed thanks for writing this patch! This looks great. My only comments are just little nits about catching errors and what you would like to do with them. You could handle them locally or raise but it would be best to be explicit about it. Other than that this looks good and I'm looking forward to trying it out

review: Needs Fixing

« Back to merge proposal