Merge lp:~hopem/charms/trusty/ceph-osd/lp1520236 into lp:~openstack-charmers-archive/charms/trusty/ceph-osd/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 57
Proposed branch: lp:~hopem/charms/trusty/ceph-osd/lp1520236
Merge into: lp:~openstack-charmers-archive/charms/trusty/ceph-osd/next
Diff against target: 36 lines (+6/-0)
3 files modified
config.yaml (+4/-0)
hooks/ceph_hooks.py (+1/-0)
templates/ceph.conf (+1/-0)
To merge this branch: bzr merge lp:~hopem/charms/trusty/ceph-osd/lp1520236
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+282433@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #16108 ceph-osd-next for hopem mp282433
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/16108/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #17243 ceph-osd-next for hopem mp282433
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/17243/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8747 ceph-osd-next for hopem mp282433
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 100
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14486745/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8747/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8749 ceph-osd-next for hopem mp282433
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8749/

Revision history for this message
Liam Young (gnuoy) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2015-07-10 14:12:01 +0000
+++ config.yaml 2016-01-13 12:49:15 +0000
@@ -1,4 +1,8 @@
1options:1options:
2 loglevel:
3 default: 1
4 type: int
5 description: OSD debug level. Max is 20.
2 osd-devices:6 osd-devices:
3 type: string7 type: string
4 default: /dev/vdb8 default: /dev/vdb
59
=== modified file 'hooks/ceph_hooks.py'
--- hooks/ceph_hooks.py 2015-10-30 02:22:54 +0000
+++ hooks/ceph_hooks.py 2016-01-13 12:49:15 +0000
@@ -83,6 +83,7 @@
83 'use_syslog': str(config('use-syslog')).lower(),83 'use_syslog': str(config('use-syslog')).lower(),
84 'ceph_public_network': config('ceph-public-network'),84 'ceph_public_network': config('ceph-public-network'),
85 'ceph_cluster_network': config('ceph-cluster-network'),85 'ceph_cluster_network': config('ceph-cluster-network'),
86 'loglevel': config('loglevel'),
86 }87 }
8788
88 if config('prefer-ipv6'):89 if config('prefer-ipv6'):
8990
=== modified file 'templates/ceph.conf'
--- templates/ceph.conf 2014-10-06 22:09:58 +0000
+++ templates/ceph.conf 2016-01-13 12:49:15 +0000
@@ -13,6 +13,7 @@
13log to syslog = {{ use_syslog }}13log to syslog = {{ use_syslog }}
14err to syslog = {{ use_syslog }}14err to syslog = {{ use_syslog }}
15clog to syslog = {{ use_syslog }}15clog to syslog = {{ use_syslog }}
16debug osd = {{ loglevel }}/5
1617
17{%- if ceph_public_network is string %}18{%- if ceph_public_network is string %}
18public network = {{ ceph_public_network }}19public network = {{ ceph_public_network }}

Subscribers

People subscribed via source and target branches