Code review comment for lp:~hopem/charms/precise/rabbitmq-server/lp1281753

Hi Ed

Looking at the addition of add_source and apt_update

1) Use in config_changed

Not sure its adding any value here - it just adds the source then updates the package indexes, rather than doing any sort of upgrade. Was the intent to allow a running environment to be upgraded?

2) apt_update usage

Please call with fatal=True - if something is foo-bared we should let users know