Code review comment for lp:~hopem/charms/precise/rabbitmq-server/lp1281753

Revision history for this message
Charles Butler (lazypower) wrote :

Greetings Edward,

Thank you for the time spent working on this modification. I've reviewed the suggested modifications and have the following knitpicky comments:

when running charm proof I received a notice:
W: config.yaml: option key does not have the keys: default

I see there are other additions that use default: None - what was the purpose of leaving it out on this particular option?

The documentation of new configuration items is fully missing. I'd like to see this updated.

Thanks again, aside from the knit picks +1 LGTM

review: Approve

« Back to merge proposal