Code review comment for lp:~hopem/charms/precise/cinder/trunk

Revision history for this message
Edward Hope-Morley (hopem) wrote :

I have fixed most points. I agree that ulitmately we should use glance relation to check what api version(s) are supported but this should not break anything as is. This value will not be set < G and even it id did it would be ignored. I have made the default v1 (which would be default even if the setting were not defined in cinder.conf). it is then up to the user to define the appropriate api version to use.

« Back to merge proposal