charm-sysconfig

Code review comment for ~hopem/charm-sysconfig:bug/1864217

  1. Git
  2. lp:~hopem/charm-sysconfig
  3. bug/1864217
  4. Merge into master
Revision history for this message
Giuseppe Petralia (peppepetra) wrote :

Hi Edward,

I have tested the MR. I see two issues:

1. on a fresh install the message of the unit is always "ready" even if the resources are updated.
2. on two consecutive update-status the message of the unit will be always set to ready.

I have suggested how to fix that (comments inline)

Also the MR needs to be rebased.

Thanks,
Giuseppe

review: Needs Fixing

« Back to merge proposal