Merge lp:~hopem/charm-helpers/lp1273469.v2 into lp:charm-helpers

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 125
Proposed branch: lp:~hopem/charm-helpers/lp1273469.v2
Merge into: lp:charm-helpers
Diff against target: 50 lines (+5/-5)
2 files modified
charmhelpers/contrib/openstack/context.py (+1/-1)
tests/contrib/openstack/test_os_contexts.py (+4/-4)
To merge this branch: bzr merge lp:~hopem/charm-helpers/lp1273469.v2
Reviewer Review Type Date Requested Status
James Page Pending
Review via email: mp+208637@code.launchpad.net

This proposal supersedes a proposal from 2014-02-27.

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote : Posted in a previous version of this proposal

21 - self.relation_get.return_value = 'http://glancehost:9292'
22 - self.assertEquals({'glance_api_servers': 'http://glancehost:9292'},
23 + self.relation_get.return_value = 'http://glancehost:9696'
24 + self.assertEquals({'glance_api_servers': 'http://glancehost:9696'},

A little over zealous on ser/rep.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charmhelpers/contrib/openstack/context.py'
--- charmhelpers/contrib/openstack/context.py 2014-02-26 14:11:16 +0000
+++ charmhelpers/contrib/openstack/context.py 2014-02-27 16:22:28 +0000
@@ -466,7 +466,7 @@
466 host = config('vip')466 host = config('vip')
467 else:467 else:
468 host = unit_get('private-address')468 host = unit_get('private-address')
469 url = '%s://%s:%s' % (proto, host, '9292')469 url = '%s://%s:%s' % (proto, host, '9696')
470 ctxt = {470 ctxt = {
471 'network_manager': self.network_manager,471 'network_manager': self.network_manager,
472 'neutron_url': url,472 'neutron_url': url,
473473
=== modified file 'tests/contrib/openstack/test_os_contexts.py'
--- tests/contrib/openstack/test_os_contexts.py 2014-02-25 22:47:13 +0000
+++ tests/contrib/openstack/test_os_contexts.py 2014-02-27 16:22:28 +0000
@@ -631,14 +631,14 @@
631 mock_is_clustered.return_value = False631 mock_is_clustered.return_value = False
632 self.assertEquals(632 self.assertEquals(
633 {'network_manager': 'neutron',633 {'network_manager': 'neutron',
634 'neutron_url': 'https://%s:9292' % (priv_addr)},634 'neutron_url': 'https://%s:9696' % (priv_addr)},
635 neutron.neutron_ctxt()635 neutron.neutron_ctxt()
636 )636 )
637637
638 mock_is_clustered.return_value = True638 mock_is_clustered.return_value = True
639 self.assertEquals(639 self.assertEquals(
640 {'network_manager': 'neutron',640 {'network_manager': 'neutron',
641 'neutron_url': 'https://%s:9292' % (vip)},641 'neutron_url': 'https://%s:9696' % (vip)},
642 neutron.neutron_ctxt()642 neutron.neutron_ctxt()
643 )643 )
644644
@@ -655,7 +655,7 @@
655 mock_neutron_ctxt):655 mock_neutron_ctxt):
656656
657 mock_neutron_ctxt.return_value = {'network_manager': 'neutron',657 mock_neutron_ctxt.return_value = {'network_manager': 'neutron',
658 'neutron_url': 'https://foo:9292'}658 'neutron_url': 'https://foo:9696'}
659 config = {'neutron-alchemy-flags': None}659 config = {'neutron-alchemy-flags': None}
660 self.config.side_effect = lambda key: config[key]660 self.config.side_effect = lambda key: config[key]
661 neutron = context.NeutronContext()661 neutron = context.NeutronContext()
@@ -677,7 +677,7 @@
677 self.assertEquals(677 self.assertEquals(
678 {'network_manager': 'neutron',678 {'network_manager': 'neutron',
679 'ovs': 'ovs_context',679 'ovs': 'ovs_context',
680 'neutron_url': 'https://foo:9292'},680 'neutron_url': 'https://foo:9696'},
681 neutron()681 neutron()
682 )682 )
683683

Subscribers

People subscribed via source and target branches