Code review comment for lp:~hopem/charm-helpers/lp1257763

Revision history for this message
Edward Hope-Morley (hopem) wrote :

> Thanks for this.
>
> If you agree with the following I'm +1 on this.
>
> === modified file 'tox.ini'
> --- tox.ini 2014-08-07 10:24:25 +0000
> +++ tox.ini 2014-08-18 17:06:39 +0000
> @@ -17,7 +17,7 @@
>
> [testenv:pep8]
> deps = -r{toxinidir}/test-requirements-trusty.txt
> -commands = flake8 --ignore=E123,E501 {posargs}
> +commands = flake8 --ignore=E123,E501 {posargs} charmhelpers
>
> [testenv:venv]
> commands = {posargs}
>
>
> Currently it runs pep8 on the whole stdlib making its long and the feedback
> ignorable.

Agreed, will fix. Thanks for reviewing.

« Back to merge proposal