Ubuntu
isc-dhcp package

Code review comment for ~holmanb/ubuntu/+source/isc-dhcp:ubuntu/devel

  1. Git
  2. lp:~holmanb/ubuntu/+source/isc-dhcp
  3. ubuntu/devel
  4. Merge into ubuntu/devel
Revision history for this message
Robie Basak (racb) wrote :

This looks fine and we can upload this now if required. One comment inline to adjust the profile relaxation to be just a bit tighter, assuming it works (please test).

However we should send this to Debian, and if they end up implementing the change differently, we'd end up have to test two different ways of doing it. So, if we have time, could you please send this to Debian for review first? This depends on what you need this for, which I don't know :-)

If however you need it quickly, then +1 to upload this to Ubuntu with just my inline comment addressed. Please let me know if so, and I'll sponsor.

review: Needs Fixing

« Back to merge proposal