Merge ~hloeung/ubuntu-repository-cache:fixes into ubuntu-repository-cache:master

Proposed by Haw Loeung
Status: Merged
Approved by: Loïc Gomez
Approved revision: 543e6ab8a3a44124db10061acb639892293888fa
Merged at revision: 3bd749b65f9657e00a8ae090a575c6dc74030994
Proposed branch: ~hloeung/ubuntu-repository-cache:fixes
Merge into: ubuntu-repository-cache:master
Diff against target: 80 lines (+2/-5)
6 files modified
lib/ubuntu_repository_cache/metadata_cleanup.py (+0/-1)
lib/ubuntu_repository_cache/metadata_peers_sync.py (+0/-1)
lib/ubuntu_repository_cache/metadata_sync.py (+0/-1)
lib/ubuntu_repository_cache/tests/test_apache.py (+0/-1)
reactive/ubuntu_repository_cache.py (+1/-1)
tests/unit/test_ubuntu_repository_cache.py (+1/-0)
Reviewer Review Type Date Requested Status
Canonical IS Reviewers Pending
Ubuntu Repository Cache Charmers, Canonical Pending
Review via email: mp+436813@code.launchpad.net

Commit message

Ignore systemd/system/snapd.mounts.target.wants/snap-* in bzrignore to reduce cron spam

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 3bd749b65f9657e00a8ae090a575c6dc74030994

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/lib/ubuntu_repository_cache/metadata_cleanup.py b/lib/ubuntu_repository_cache/metadata_cleanup.py
index 6d74cf5..2e2d350 100644
--- a/lib/ubuntu_repository_cache/metadata_cleanup.py
+++ b/lib/ubuntu_repository_cache/metadata_cleanup.py
@@ -20,7 +20,6 @@ def main(environment, log):
2020
2121
22if __name__ == "__main__":22if __name__ == "__main__":
23
24 # Use the logging infrastructure to print messages with timestamps to23 # Use the logging infrastructure to print messages with timestamps to
25 # stdout. This is a cheap way to get good timestamps. Ideally we should24 # stdout. This is a cheap way to get good timestamps. Ideally we should
26 # move to leverage the logging infrastructure better. ~tribaal25 # move to leverage the logging infrastructure better. ~tribaal
diff --git a/lib/ubuntu_repository_cache/metadata_peers_sync.py b/lib/ubuntu_repository_cache/metadata_peers_sync.py
index 7ab5bd1..e129bfc 100644
--- a/lib/ubuntu_repository_cache/metadata_peers_sync.py
+++ b/lib/ubuntu_repository_cache/metadata_peers_sync.py
@@ -82,7 +82,6 @@ def ubuntu_repository_cache_sync(environment, log):
8282
8383
84if __name__ == "__main__":84if __name__ == "__main__":
85
86 # Use the logging infrastructure to print messages with timestamps to85 # Use the logging infrastructure to print messages with timestamps to
87 # stdout. This is a cheap way to get good timestamps. Ideally we should86 # stdout. This is a cheap way to get good timestamps. Ideally we should
88 # move to leverage the logging infrastructure better. ~tribaal87 # move to leverage the logging infrastructure better. ~tribaal
diff --git a/lib/ubuntu_repository_cache/metadata_sync.py b/lib/ubuntu_repository_cache/metadata_sync.py
index cbc01b3..d428f3d 100644
--- a/lib/ubuntu_repository_cache/metadata_sync.py
+++ b/lib/ubuntu_repository_cache/metadata_sync.py
@@ -621,7 +621,6 @@ def _verify_distribution(path, release):
621621
622622
623if __name__ == "__main__":623if __name__ == "__main__":
624
625 # Use the logging infrastructure to print messages with timestamps to624 # Use the logging infrastructure to print messages with timestamps to
626 # stdout. This is a cheap way to get good timestamps. Ideally we should625 # stdout. This is a cheap way to get good timestamps. Ideally we should
627 # move to leverage the logging infrastructure better. ~tribaal626 # move to leverage the logging infrastructure better. ~tribaal
diff --git a/lib/ubuntu_repository_cache/tests/test_apache.py b/lib/ubuntu_repository_cache/tests/test_apache.py
index aef2b7a..8de4501 100644
--- a/lib/ubuntu_repository_cache/tests/test_apache.py
+++ b/lib/ubuntu_repository_cache/tests/test_apache.py
@@ -24,7 +24,6 @@ class ApacheTestCase(unittest.TestCase):
2424
25 @mock.patch('multiprocessing.cpu_count')25 @mock.patch('multiprocessing.cpu_count')
26 def test_tune_mpm_configs(self, cpu_count):26 def test_tune_mpm_configs(self, cpu_count):
27
28 cpu_count.return_value = 427 cpu_count.return_value = 4
29 config = {28 config = {
30 'startservers': 0,29 'startservers': 0,
diff --git a/reactive/ubuntu_repository_cache.py b/reactive/ubuntu_repository_cache.py
index c6f7246..101c686 100755
--- a/reactive/ubuntu_repository_cache.py
+++ b/reactive/ubuntu_repository_cache.py
@@ -421,6 +421,7 @@ systemd/system/default.target.wants/snap-*.mount
421systemd/system/default.target.wants/snap-*.service421systemd/system/default.target.wants/snap-*.service
422systemd/system/snap-*.mount422systemd/system/snap-*.mount
423systemd/system/snap.*.service423systemd/system/snap.*.service
424systemd/system/snapd.mounts.target.wants/snap-*.mount
424# end section ignore due to LP#1598304425# end section ignore due to LP#1598304
425'''426'''
426 _write_file('\n'.join(new) + ignore_snaps, bzrignore_path, perms=0o600)427 _write_file('\n'.join(new) + ignore_snaps, bzrignore_path, perms=0o600)
@@ -483,7 +484,6 @@ def _write_file(source, dest_path, perms=0o644, owner=None, group=None):
483484
484485
485def _update_aliases(admin_email='', aliases_path='/etc/aliases'):486def _update_aliases(admin_email='', aliases_path='/etc/aliases'):
486
487 aliases = []487 aliases = []
488 try:488 try:
489 with open(aliases_path, 'r') as f:489 with open(aliases_path, 'r') as f:
diff --git a/tests/unit/test_ubuntu_repository_cache.py b/tests/unit/test_ubuntu_repository_cache.py
index e73e27c..1dd66fb 100644
--- a/tests/unit/test_ubuntu_repository_cache.py
+++ b/tests/unit/test_ubuntu_repository_cache.py
@@ -133,6 +133,7 @@ systemd/system/default.target.wants/snap-*.mount
133systemd/system/default.target.wants/snap-*.service133systemd/system/default.target.wants/snap-*.service
134systemd/system/snap-*.mount134systemd/system/snap-*.mount
135systemd/system/snap.*.service135systemd/system/snap.*.service
136systemd/system/snapd.mounts.target.wants/snap-*.mount
136# end section ignore due to LP#1598304137# end section ignore due to LP#1598304
137'''138'''
138 with open(bzrignore_path, 'r', encoding='utf-8') as f:139 with open(bzrignore_path, 'r', encoding='utf-8') as f:

Subscribers

People subscribed via source and target branches