Code review comment for lp:~hloeung/landscape-client-charm/show-charm-source-version

Revision history for this message
Simon Poirier (simpoir) wrote :

Although I do like some useful debug info, I see a few small things:
1) Obvious but essential nitpick. please run `make lint`. Some lines are too long.
2) I see no reason to truncate revisions. This is not git and we're not saving saving bytes here.
3) The truncated version is useless as this is a bzr repo (e.g. <email address hidden> truncates to 'haw.loeu…')
4) This seems like it would be more useful in the debug logs than just in the ephemeral status line. What's the exact use case?

review: Needs Fixing

« Back to merge proposal