Code review comment for ~hloeung/influxdb-charm:master

Revision history for this message
Haw Loeung (hloeung) wrote :

$ juju config influxdb ip_address='127.0.0.1'

| ubuntu@juju-b884ff-canonistack-haw-lcy02-4:~$ diff -Naurp /etc/influxdb/{influxdb.conf.orig,influxdb.conf}
| --- /etc/influxdb/influxdb.conf.orig 2017-11-03 00:10:10.743762811 +0000
| +++ /etc/influxdb/influxdb.conf 2017-11-03 00:22:05.160094893 +0000
| @@ -201,7 +201,7 @@
| # enabled = true
|
| # The bind address used by the HTTP service.
| - # bind-address = ":8086"
| + bind-address = "127.0.0.1:8086"
|
| # Determines whether user authentication is enabled over HTTP/HTTPS.
| # auth-enabled = false
| ===

$ juju config influxdb ip_address='127.0.0.1' bind_port='8087'

| ubuntu@juju-b884ff-canonistack-haw-lcy02-4:~$ diff -Naurp /etc/influxdb/{influxdb.conf.orig,influxdb.conf}
| --- /etc/influxdb/influxdb.conf.orig 2017-11-03 00:10:10.743762811 +0000
| +++ /etc/influxdb/influxdb.conf 2017-11-03 00:24:00.227707065 +0000
| @@ -201,7 +201,7 @@
| # enabled = true
|
| # The bind address used by the HTTP service.
| - # bind-address = ":8086"
| + bind-address = "127.0.0.1:8087"
|
| # Determines whether user authentication is enabled over HTTP/HTTPS.
| # auth-enabled = false

$ juju config influxdb extra_config="- global.hostname=myhost
- http.auth-enabled=true
- data.max-series-per-database=0
"

| ubuntu@juju-b884ff-canonistack-haw-lcy02-4:~$ diff -Naurp /etc/influxdb/{influxdb.conf.orig,influxdb.conf}
| --- /etc/influxdb/influxdb.conf.orig 2017-11-03 00:10:10.743762811 +0000
| +++ /etc/influxdb/influxdb.conf 2017-11-03 00:25:45.242181284 +0000
| @@ -14,6 +14,8 @@
| # Bind address to use for the RPC service for backup and restore.
| # bind-address = "127.0.0.1:8088"
|
| +hostname = "myhost"
| +
| ###
| ### [meta]
| ###
| @@ -95,7 +97,7 @@
| # The maximum series allowed per database before writes are dropped. This limit can prevent
| # high cardinality issues at the database level. This limit can be disabled by setting it to
| # 0.
| - # max-series-per-database = 1000000
| + max-series-per-database = 0
|
| # The maximum number of tag values per tag that are allowed before writes are dropped. This limit
| # can prevent high cardinality tag values from being written to a measurement. This limit can be
| @@ -204,7 +206,7 @@
| # bind-address = ":8086"
|
| # Determines whether user authentication is enabled over HTTP/HTTPS.
| - # auth-enabled = false
| + auth-enabled = true
|
| # The default realm sent back when issuing a basic auth challenge.
| # realm = "InfluxDB"

« Back to merge proposal