The code is fine; thank you for writing this patch.
One issue is that now half of indicator-power's menu is filled with display toggles. Maybe it would make more sense in the panel.
Most importantly, though, the feature's placement (and existence) needs to be signed-off by Design. This change isn't in mpt's spec <https://wiki.ubuntu.com/Power> so I'm not approving this patch as-is. Please ping mpt and ask him to re-engage on this ticket.
One final option would be to make this an "invisible" feature accessible through dconf-editor, much like indicator-bluetooth's visibility toggle or indicator-datetime's custom-time-format string.
The code is fine; thank you for writing this patch.
One issue is that now half of indicator-power's menu is filled with display toggles. Maybe it would make more sense in the panel.
Most importantly, though, the feature's placement (and existence) needs to be signed-off by Design. This change isn't in mpt's spec <https:/ /wiki.ubuntu. com/Power> so I'm not approving this patch as-is. Please ping mpt and ask him to re-engage on this ticket.
One final option would be to make this an "invisible" feature accessible through dconf-editor, much like indicator- bluetooth' s visibility toggle or indicator- datetime' s custom-time-format string.