Code review comment for ~hloeung/content-cache-charm:master

Revision history for this message
Stuart Bishop (stub) wrote :

Yup, all good.

You may be able to replace the status reset_mocks with a single one, doing charms.layer.reset_mock() in the TestCase's setUp method.

It would be possible to target the status mock by installing the MagicMock at charms.layer.status instead of charms.layer. However, what you have may be more useful as pretty much anything that comes from charms.layer will need to be mocked.

review: Approve

« Back to merge proposal