Code review comment for ~hloeung/charm-telegraf:master

Revision history for this message
Haw Loeung (hloeung) wrote :

Would it help being accepted if I drop commit b73a4e4 adding Xenial support to charmcraft.yaml? That way it won't appear to be supported on Charm hub.

But we retain the Python package pinning in wheelhouse.txt so the charm would continue to work on Xenial. The wheelhouse.txt changes bumps the versions for requests and urllib3 but pins and drops versions for MarkupSafe, Jinja2, and certifi. That's currently:

MarkupSafe-2.0.1.tar.gz -> MarkupSafe-1.1.1.tar.gz
Jinja2-3.0.3.tar.gz -> Jinja2-2.11.0.tar.gz
certifi-2022.12.7.tar.gz -> certifi-2021.10.8.tar.gz

The reason for doing this is because we currently still have systems using Xenial. Using mojo with bundles automatically upgrades the charms or pushes the latest charms[1]. We're using a single Juju subordinate application that's related to applications of different series[2] so would be nice to not have a separate "xenial" branch/channel.

[1]https://pastebin.canonical.com/p/gd95cKk4yQ/
[2]https://pastebin.canonical.com/p/J6vjbzMwhv/

« Back to merge proposal