Code review comment for lp:~hloeung/charm-haproxy/bump-global-dh-param

Revision history for this message
Tom Haddon (mthaddon) wrote :

One comment about the description field.

I also have a question about the fact that java 7 is the default on trusty. This will break new deployments on trusty that don't specify global_default_dh_param explicitly. I think our options are to:

1) Drop support for trusty
2) Update the code to fallback to 1024 if java 7 or lower is installed despite the setting of this config option
3) Leave it as is and essentially require anyone deploying with java 7 to set this to 1024 manually.

I don't see any references to java or openjdk in the charm code - do we know why this is called out explicitly? What is java potentially being used for here? Looks like this description was added in revno 88 on 205-02-20.

« Back to merge proposal