Code review comment for ~hloeung/charm-graylog:master

Revision history for this message
Tim Kuhlman (timkuhlman) wrote :

Nice new functionality!

I think the implementation can be improved with some unit tests and by pulling all of the Graylog API code into a library, ideally one that can be shared between the reactive code and the amulet tests.

Also this is pretty significant new functionality, the Amulet tests should be extended to cover setting and verifying log_inputs.

review: Needs Fixing

« Back to merge proposal