Code review comment for lp:~hjd/widelands/ware-data

Revision history for this message
Nasenbaer (nasenbaer) wrote :

I partly disagree with SirVer in this case - the log(.......) stuff should of course not be translated (and it is not at the moment), but the game data error should be translated, as in nearly all cases this bug is triggered through user modified data - that's why the game data error was introduced, to directly show, that widelands is running as it should, but just some game data is somehow messed up.

Anyway: the first part of the fix is wrong because it really ist "waredata data" - just take a look one line below - the package that is about to be read is waredata_data.

The second part is fine for me.

review: Needs Fixing

« Back to merge proposal